search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
229 stars 63 forks source link

Replace deprecated klog.New in tests with ktesting.NewTestContext #352

Closed erikgb closed 1 month ago

erikgb commented 1 month ago

The function klogr,New has been deprecated. Instead of migrating to the suggested replacement, I propose to use ktesting.NewTestContext in tests instead - which is already in use in this project.

For trust-manager (main) I would suggest migrating to the relatively new GO stdlib log (slog) - with a target to address https://github.com/cert-manager/trust-manager/issues/282. I will try to do this in a follow up PR.

inteon commented 1 month ago

/approve /lgtm

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment