fix use of system trust bundle when building package

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.

https://cert-manager.io/docs/projects/trust-manager/

Apache License 2.0

251 stars 66 forks source link

fix use of system trust bundle when building package #355

Closed SgtCoDFish closed 4 months ago

SgtCoDFish commented 4 months ago

I missed this during the review of #195 . I shouldn't have missed such a huge bug - my bad!

Today this script uses the system's trust-bundle, not the one from the container.

It breaks development on all platforms which aren't Debian-based linux (e.g. macOS, RHEL, etc)

It shouldn't lead to an incorrect bundle being pushed upstream and we're safe there I think, but it needs fixing as a matter of urgency in case our workflows or the bundle changes in the future.

SgtCoDFish commented 4 months ago

/approve

cert-manager-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ThatsMrTalbot commented 4 months ago

/lgtm