search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
229 stars 63 forks source link

Deduplicate code for syncing target configmaps and secrets #356

Closed erikgb closed 1 month ago

erikgb commented 1 month ago

Currently, the code for syncing target configmaps and secrets is separate - even if the logic should be the same. This doesn't make it tempting to add new features to bundle targets. In this PR I made an attempt to duplicate some of the code. We could probably do more, but let me know what you think before I spend more time on this! ☺️

cert-manager-prow[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/cc @inteon

inteon commented 1 month ago

Thanks @erikgb. I would like you to continue making improvements, let's do it in separate PRs.

/approve /lgtm

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment