search

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
229 stars 63 forks source link

Fix all linter issues and un-ignore golanci-lint linter exceptions #360

Closed inteon closed 1 month ago

inteon commented 1 month ago

Each commit removes one linter exception.

ThatsMrTalbot commented 1 month ago

/lgtm

erikgb commented 1 month ago

LGTM, but build is failing because of invalid checksum for "/home/prow/go/src/github.com/cert-manager/trust-manager/_bin/downloaded/tools/kubebuilder_tools_1.30.0_linux_amd64.tar.gz.tmp": wanted "d51dae845397b7548444157903f2d573493afb6f90ce9417c0f5c61d4b1f908d" but got "00fb1322a3da606e90586d2327abe797cea3a6e199a37d3bb2fbef6d8f5fc6bb"

inteon commented 1 month ago

/retest

inteon commented 1 month ago

LGTM, but build is failing because of invalid checksum for "/home/prow/go/src/github.com/cert-manager/trust-manager/_bin/downloaded/tools/kubebuilder_tools_1.30.0_linux_amd64.tar.gz.tmp": wanted "d51dae845397b7548444157903f2d573493afb6f90ce9417c0f5c61d4b1f908d" but got "00fb1322a3da606e90586d2327abe797cea3a6e199a37d3bb2fbef6d8f5fc6bb"

Should have been fixed in https://github.com/cert-manager/trust-manager/pull/361.

erikgb commented 1 month ago

Thanks a lot for fixing this @inteon!

/lgtm /approve

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [erikgb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment