re-add support for s390x

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.

https://cert-manager.io/docs/projects/trust-manager/

Apache License 2.0

251 stars 66 forks source link

re-add support for s390x #366

Closed SgtCoDFish closed 4 months ago

SgtCoDFish commented 4 months ago

In #315 we added support for s390x, but this was unintentionally removed in v0.10.0 due to the makefile modules changes. This PR re-adds support for s390x.

It depended on a new base image being built for s390x (via https://github.com/cert-manager/base-images/pull/5), which wasn't previously available.

Confirmed locally that make oci-build-manager oci-build-package_debian builds s390x versions of both.

ThatsMrTalbot commented 4 months ago

/lgtm

SgtCoDFish commented 4 months ago

/approve

cert-manager-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment