refactor: split bundle sync code into source and target

cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.

https://cert-manager.io/docs/projects/trust-manager/

Apache License 2.0

229 stars 63 forks source link

refactor: split bundle sync code into source and target #370

Closed erikgb closed 3 weeks ago

erikgb commented 4 weeks ago

I find the current sync code (including test) too large to work effectively with improvements. In this PR I have tried to separate the source and target part of the sync. The split is probably not perfect, but it's at least a start.

inteon commented 3 weeks ago

@erikgb I agree with the change. I'm assuming you only moved code and did not make changes? Feel free to unhold if this is the case. /approve /lgtm /hold

cert-manager-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

erikgb commented 3 weeks ago

I'm assuming you only moved code and did not make changes? Feel free to unhold if this is the case.

The only thing I changed was to add an import alias for meta/v1 package.

/unhold