cert-manager / trust-manager

trust-manager is an operator for distributing trust bundles across a Kubernetes cluster.
https://cert-manager.io/docs/projects/trust-manager/
Apache License 2.0
243 stars 65 forks source link

WIP: refactor: establish target.Reconciler #378

Open erikgb opened 1 month ago

erikgb commented 1 month ago

This is a major refactor of the bundle target area. The main motivation is to prepare the grounds for https://github.com/cert-manager/trust-manager/issues/58 and https://github.com/cert-manager/trust-manager/issues/222.

The refactoring became larger because I had to move some fields and functions to avoid circular package dependencies. I would be happy to split these changes out in pre-PRs if desired.

cert-manager-prow[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from erikgb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/trust-manager/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/test all

erikgb commented 1 month ago

/cc @inteon