Closed jabdoa2 closed 1 month ago
Hi @jabdoa2. Thanks for your PR.
I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks, @jabdoa2! I think it makes sense to allow these values to be configured. WDYT?
Thanks, @jabdoa2! I think it makes sense to allow these values to be configured. WDYT?
done.
/ok-to-test
/approve
Changes looks good to me. Can you try to figure out why CI is failing and squash commits, please @jabdoa2?
Test is fixed and commits are squashed. Should be good to go.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This change will prevent trust-manager from restart looping when kube API server is (over-)loaded. Most kubernetes operators increase this value as the default (15s) is too low under load.