Closed guntiskarulis closed 2 weeks ago
Hi @guntiskarulis. Thanks for your PR.
I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/approve
Thanks @guntiskarulis! If you make CI happy, I will allow this to merge. Are you able to squash commits into a single one before we merge?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks @guntiskarulis! 🚀
/lgtm
Pull Request Motivation Some environments have admission webhooks that might mandate specific labels or annotations. This change allows chart users to set labels and/or annotations in the Secret created by the Certificate resources.
Close https://github.com/cert-manager/trust-manager/issues/453