rikatz
commented
4 years ago /assign @munnerz
Closed rikatz closed 4 years ago
rikatz
commented
4 years ago /assign @munnerz
james-w
commented
4 years ago Hi, thanks for the contribution.
When were those stable APIs added?
This is just an example so we don't have to worry about compatibility too much, but it's good to be compatible with the versions that most people are going to be running in the wild.
Thanks,
James
james-w
commented
4 years ago Looking at 1.14:
It has
The others are the cert-manager.io APIs, where we can reasonably assume that people are up to date, so
/lgtm
Thanks!
munnerz
commented
4 years ago /approve
On Wed, 15 Jul 2020 at 09:03, James Westby notifications@github.com wrote:
Looking at 1.14:
It has
- apiregistration.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apiservice-v1-apiregistration-k8s-io
- apps/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apps-v1
- rbac.authorization.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#rolebinding-v1-rbac-authorization-k8s-io
The others are the cert-manager.io APIs, where we can reasonably assume that people are up to date, so
/lgtm
Thanks!
— You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/jetstack/cert-manager-webhook-example/pull/12#issuecomment-658612834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRWP4ZETLQS5B2LJTSRHLR3VPDRANCNFSM4ODBGR3Q .
jetstack-bot
commented
4 years ago [APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: munnerz, rikatz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This changes the Helm Chart templates to remove deprecated APIs and use the stable ones.