Fix deprecated annotation in helm template

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook

Apache License 2.0

107 stars 419 forks source link

Fix deprecated annotation in helm template #14

Closed bengentil closed 3 years ago

bengentil commented 4 years ago

This deprecated annotation cause the communication between apiserver and the webhook to fail with the following message:

loading OpenAPI spec for "v1alpha1.acme.example.com" failed with: failed to retrieve openAPI spec, http error: ResponseCode: 503, Body: Error trying to reach service: 'x509: certificate signed by unknown authority'

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bengentil To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jetstack/cert-manager-webhook-example/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jakexks commented 3 years ago

Thanks, this has been updated /close

jetstack-bot commented 3 years ago

@jakexks: Closed this PR.

In response to [this](https://github.com/jetstack/cert-manager-webhook-example/pull/14#issuecomment-784158350): >Thanks, this has been updated >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.