search

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
103 stars 407 forks source link

updating miekg/dns just a bit to fix a bug and don't breaking everything else #19

Closed 4nx closed 3 years ago

4nx commented 3 years ago

Within miekg/dns v1.0.5 a bug was fixed.

The project had the bug until version 1.0.4:

https://github.com/miekg/dns/blob/5364553f1ee9cddc7ac8b62dce148309c386695b/clientconfig.go#L94

which had been fixed in version 1.0.5 after this pull request miekg/dns#642 through:

miekg/dns@0079071

jetstack-bot commented 3 years ago

@4nx: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jakexks commented 3 years ago

Thanks, this should now be fixed as part of bumping cert-manager /close

jetstack-bot commented 3 years ago

@jakexks: Closed this PR.

In response to [this](https://github.com/jetstack/cert-manager-webhook-example/pull/19#issuecomment-784156727): >Thanks, this should now be fixed as part of bumping cert-manager >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.