update script to fetch test binaries

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook

Apache License 2.0

103 stars 407 forks source link

update script to fetch test binaries #20

Closed mansona closed 3 years ago

mansona commented 3 years ago

Hey folks 👋

I'm super new to Go so I'm kinda struggling to setup my webhook from this example repo 🙈 I did notice there was some chatter in https://github.com/jetstack/cert-manager-webhook-example/issues/3 to make this a little simpler for beginners so I thought I would update the script that downloads the binary files.

I know there was an example script in that issue but I instead took inspiration from https://go.kubebuilder.io/quick-start.html 👍

Let me know if you want me to update anything to help get this merged

jetstack-bot commented 3 years ago

@mansona: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jakexks commented 3 years ago

Hi, thanks for your contribution! I tidied up the repo based on the outstanding PRs, so hopefully make test will now work for this use case. /close

jetstack-bot commented 3 years ago

@jakexks: Closed this PR.

In response to [this](https://github.com/jetstack/cert-manager-webhook-example/pull/20#issuecomment-784156146): >Hi, thanks for your contribution! >I tidied up the repo based on the outstanding PRs, so hopefully `make test` will now work for this use case. >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.