cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
102 stars 405 forks source link

integration test example does not work with certmanager v1.5.0 #32

Closed secustor closed 2 years ago

secustor commented 3 years ago

With v1.5.0 the test function dns.SetBinariesPath() has been removed and therefore the test example does not work anymore.

I have tried to adapt the test, but I have failed so far.

Dr-Shadow commented 3 years ago

You can use the environnent variables to pass the path to etcd / kube-apiserver and kubectl binaries.

TEST_ASSET_ETCD=./hack/bin/etcd TEST_ASSET_KUBE_APISERVER=./hack/bin/kube-apiserver TEST_ASSET_KUBECTL=./hack/bin/kubectl TEST_ZONE_NAME=<ZONE_NAME>. go test -v .

secustor commented 3 years ago

@Dr-Shadow Thx! This has helped me a lot!

wallrj commented 2 years ago

Fixed in #36 (I think)