cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
102 stars 405 forks source link

Catch up #42

Closed anon-software closed 1 year ago

anon-software commented 2 years ago

The web-hook example seems to be lagging behind cert-manager in version, including the repository name. There are two commits to sync them up, the first bring it up to 1.8.2 and the second to 1.9.1. There is also another commit to make it work on arm64 architecture.

jetstack-bot commented 2 years ago

Hi @anon-software. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
inteon commented 1 year ago

/ok-to-test

aureq commented 1 year ago

@anon-software is there any chance you could document how you upgraded the dependencies please? Specifically, the commands used.

Thank you

anon-software commented 1 year ago

I cannot remember exactly. I know that I deleted go.sum file, modified go.mod and then ran "go mod tidy" command. One version of the modified go.mod file that produces the current version in the pull request follows.

module github.com/cert-manager/webhook-example

go 1.18

require (
        github.com/cert-manager/cert-manager v1.9.1
        github.com/miekg/dns v1.1.47
        github.com/stretchr/testify v1.7.1
        k8s.io/apiextensions-apiserver v0.24.2
        k8s.io/client-go v0.24.2
)

replace (
        github.com/containerd/containerd => github.com/containerd/containerd v1.5.10
        github.com/miekg/dns v1.1.41 => github.com/miekg/dns v1.1.34
        go.opentelemetry.io/contrib => go.opentelemetry.io/contrib v0.20.0
        go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc => go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.20.0
        go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.20.0
        go.opentelemetry.io/otel => go.opentelemetry.io/otel v0.20.0
        go.opentelemetry.io/otel/exporters/otlp => go.opentelemetry.io/otel/exporters/otlp v0.20.0
        go.opentelemetry.io/otel/metric => go.opentelemetry.io/otel/metric v0.20.0
        go.opentelemetry.io/otel/oteltest => go.opentelemetry.io/otel/oteltest v0.20.0
        go.opentelemetry.io/otel/sdk => go.opentelemetry.io/otel/sdk v0.20.0
        go.opentelemetry.io/otel/sdk/export/metric => go.opentelemetry.io/otel/sdk/export/metric v0.20.0
        go.opentelemetry.io/otel/sdk/metric => go.opentelemetry.io/otel/sdk/metric v0.20.0
        go.opentelemetry.io/otel/trace => go.opentelemetry.io/otel/trace v0.20.0
        go.opentelemetry.io/proto/otlp => go.opentelemetry.io/proto/otlp v0.7.0
        golang.org/x/net => golang.org/x/net v0.0.0-20210224082022-3d97a244fca7

        // Update gengo to ensure we have the --trim-path-prefix feature in code-generator tools.
        k8s.io/gengo => k8s.io/gengo v0.0.0-20211115164449-b448ea381d54
)
jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anon-software, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/webhook-example/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment