search

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
102 stars 405 forks source link

Bumps dependency versions #50

Closed irbekrm closed 10 months ago

irbekrm commented 1 year ago

This PR:

jetstack-bot commented 10 months ago

@SgtCoDFish: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/cert-manager/webhook-example/pull/50#pullrequestreview-1696806730): >/lgtm >/approve > >(thank you from across time! I'll add manual labels since I'm not an owner) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SgtCoDFish Once this PR has been reviewed and has the lgtm label, please ask for approval from irbekrm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/webhook-example/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SgtCoDFish commented 10 months ago

/test pull-cert-manager-webhook-example-verify

jetstack-bot commented 10 months ago

@irbekrm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-webhook-example-verify 99cc0cd2e47e210926fd9a03c5df6db89cd61fd9 link true /test pull-cert-manager-webhook-example-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
SgtCoDFish commented 10 months ago

Ah the failure is legit; I'll close this PR and take an updated fresh look at it. Thanks Irbe!