cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Reorganise 'Certificate resource' page #1327

Closed inteon closed 11 months ago

inteon commented 11 months ago

This PR improves the structure of the 'Certificate resource' page.

One notable difference is the https://deploy-preview-1327--cert-manager-website.netlify.app/docs/usage/certificate/#reissuance-triggered-by-expiry-renewal section (that was actually talking about the different ways to trigger reissuance) is now moved and renamed to a "Reissuance triggered by user actions " https://deploy-preview-1327--cert-manager-website.netlify.app/docs/usage/certificate/#reissuance-triggered-by-user-actions section in the new structure.

Other changes: grouped all the sections about the different Certificate properties in the "Creating Certificate Resources" section.

Before:

After:

Before After
cert-manager io_ deploy-preview-1327--cert-manager-website netlify app_docs_usage_certificate
netlify[bot] commented 11 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit beca28894e68c4f63d812a57cc1b1b4f08f9a219
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65391c82b96ce60007c8ae94
Deploy Preview https://deploy-preview-1327--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maelvls commented 11 months ago

Hey. I looked at the right menu, it seems OK to me:

At first I was a bit confused by "Issuance triggers" vs. "Issuance behavior" but I could not think of any other way of presenting that.

I am happy with the refactoring.

/lgtm /approve

jetstack-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [maelvls] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment