cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

fix: Docs needed Camel case feature gate names #1328

Closed hawksight closed 11 months ago

hawksight commented 11 months ago

On upgrading to 1.13.1 I tried to use the examples in the documentation. However I got the following errors:

E1017 13:05:38.038480       1 main.go:39] "cert-manager: error executing command" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: experimentalGatewayAPISupport"
E1017 13:08:16.019948       1 main.go:35] "cert-manager: error executing command" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: additionalCertificateOutputFormats"

Tackling this I just needed to capitalise the first letters, which puts the config inline with command like --extraArgs options.

Signed-off-by: Peter Fiddes peter.fiddes@gmail.com

netlify[bot] commented 11 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit f0af5f63281a4a10b4286df86c05a4d84a9d8863
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/652ea4b5e94124000a5f073b
Deploy Preview https://deploy-preview-1328--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hawksight commented 11 months ago

Quick screenshot of the new:

image

inteon commented 11 months ago

Thanks @hawksight /approve /lgtm

jetstack-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment