search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

docs: Small typo on best practice: is should have been us #1342

Closed WyriHaximus closed 10 months ago

netlify[bot] commented 10 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 1c4461345770b1988557faf0d2ba7c5549c89ff3
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/654c9c804629040008e744eb
Deploy Preview https://deploy-preview-1342--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
WyriHaximus commented 10 months ago

Thanks @WyriHaximus

Out of interest, have you enabled the controller liveness probe in production? Found any circumstances where the controller has become stuck?

No problem @wallrj, I was actually surprised to read the liveness prob isn't enabled by default. Just enabled it on my personal clusters. Will discuss it with my team at work tonight, and report any issues we run into.