search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 337 forks source link

Link to the official Flux example repo and remove unnecessary --crds flags from example #1343

Closed wallrj closed 1 year ago

wallrj commented 1 year ago

Preview: https://deploy-preview-1343--cert-manager-website.netlify.app/docs/installation/continuous-deployment-and-gitops/#using-the-flux-helm-controller

  1. Linked to official Flux example repo

    In https://github.com/fluxcd/flux2/discussions/3009#discussioncomment-7508833 @stefanprodan wrote:

    cert-manager is now fully integrated in the official Flux example repo, including deploying Cluster Issuers in the right order, after cert-manager CRDs and controller have been installed. it would great if you could add a link to https://github.com/fluxcd/flux2-kustomize-helm- example/blob/main/infrastructure/controllers/cert-manager.yaml for a GitOps example

  2. Removed --crds CreateReplace because cert-manager CRDs do not use the Helm crds/ directory.

    In https://github.com/fluxcd/flux2/discussions/3009#discussioncomment-7510213 @stefanprodan wrote:

    CreateReplace will not do anything if there is no crds dir inside the chart.

netlify[bot] commented 1 year ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 352805e8cbffbe11fbadc7a859e636cf1d6c1351
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/654cdf56b8da540008b0ba2c
Deploy Preview https://deploy-preview-1343--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

inteon commented 1 year ago

/lgtm since Peter already reviewed the PR

wallrj commented 1 year ago

@inteon /lgtm doesn't work if you add a trailing remark, unlike /hold because .... Not sure why.

inteon commented 1 year ago

/lgtm

jetstack-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hawksight, stefanprodan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment