cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

cert-manager installation using argocd #1350

Closed shahkv95 closed 6 months ago

shahkv95 commented 10 months ago

Preview: https://deploy-preview-1350--cert-manager-website.netlify.app/docs/installation/continuous-deployment-and-gitops/#using-argocd

Linked issue: https://github.com/cert-manager/cert-manager/issues/4114

jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 10 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 5098cdbdbdd039e1e6572a67007cfc12e2ca2a2d
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6562d3ed3e098f00088d3cea
Deploy Preview https://deploy-preview-1350--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shahkv95 commented 10 months ago

@jsoref @wallrj have addressed and updated the PR with necessary changes in accordance with the comments.

Can you resolve the comments if you are good with it? Thank you!

matthiashaasesourceforge commented 8 months ago

what's going on here ? what's the status ?

wallrj commented 6 months ago

@shahkv95 I don't have permission to push to your branch, so I've pushed your commits to my own branch, rebased and addressed my latest code review comments there:

I'll close this PR and we can continue the work there.