search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 337 forks source link

[release-next] Fast-forward master into release-next #1357

Closed maelvls closed 11 months ago

maelvls commented 11 months ago

Tanuj needs the release-next branch to be up to date so that he knows where to put the documentation about nameConstraints.

/hold

I want to hold Prow from auto-merging this PR we prefer not having needless merge commits when master can be fast-forwarded to release-next. Once this PR gets approved, I run the following commands:

git checkout release-next
git pull
git fetch origin master
git merge --ff-only origin/master

/override dco

I used the command /override dco is necessary because some the merge commits have been written by the bot and do not have a DCO signoff. The command /override dco needs to be re-issued every time a commit is merged to master.

jetstack-bot commented 11 months ago

@maelvls: Overrode contexts on behalf of maelvls: dco

In response to [this](https://github.com/cert-manager/website/pull/1357): > > >/override dco Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maelvls commented 11 months ago

/override dco

jetstack-bot commented 11 months ago

@maelvls: Overrode contexts on behalf of maelvls: dco

In response to [this](https://github.com/cert-manager/website/pull/1357#issuecomment-1845132513): >/override dco Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 11 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 550f1f160c6894379e6dbf5a2afe49ba6be268b7
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6571ad3a34ddd80008a63190
Deploy Preview https://deploy-preview-1357--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

inteon commented 11 months ago

/approve /lgtm

jetstack-bot commented 11 months ago

@inteon: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/cert-manager/website/pull/1357#issuecomment-1845149741): >/approve >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jetstack-bot commented 11 months ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
inteon commented 11 months ago

@mael can you force push the master branch to release-next instead? That will prevent a merge commit from being created.

maelvls commented 11 months ago

/override dco

jetstack-bot commented 11 months ago

@maelvls: Overrode contexts on behalf of maelvls: dco

In response to [this](https://github.com/cert-manager/website/pull/1357#issuecomment-1845230275): >/override dco Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maelvls commented 11 months ago

We decided to let the person click "Merge" in the UI instead of waiting for someone to approve to avoid having to ask another person to do this task. See decision in Slack.

To be added to the contributor documentation:

If you find that the release-next branch is missing some changes from master and are a GitHub admin of the website repository, you can click "Merge" in the UI instead of waiting for someone to approve to avoid having to ask another person to do this task.

/approve

Can someone LGTM? 😅

jetstack-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/release-next/OWNERS)~~ [maelvls] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
inteon commented 11 months ago

/lgtm

jetstack-bot commented 11 months ago

@inteon: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/cert-manager/website/pull/1357#issuecomment-1845256976): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maelvls commented 11 months ago

~/hold~

~I want to hold Prow from auto-merging this PR we prefer not having needless merge commits when master can be fast-forwarded to release-next.~

Richard agreed that we don't need another dev interaction for merging this kind of PR. I will click "Merge" manually.