cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Adjust the release process: Sign off the cmd/ctl and push the tag only after merging the PR #1363

Closed wallrj closed 9 months ago

wallrj commented 9 months ago

Preview: https://deploy-preview-1363--cert-manager-website.netlify.app/docs/contributing/release-process/#process-for-releasing-a-version

While releasing v1.13.3, I didn't signoff the commit which updates the cmd/ctl/go.mod file, which caused the PR to fail the DCO checks.

The problem was compounded by the fact that I had already pushed the cmd/ctl@v1.13.3 tag to the cert-manager repo.

wallrj commented 9 months ago

/hold until I've tested these instructions in the v1.12.7 release.

netlify[bot] commented 9 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 17426e22d02c495e62cf1cda7798841815d3d032
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6578815bd2912c00085dcde9
Deploy Preview https://deploy-preview-1363--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maelvls commented 9 months ago

Hey. Thanks for updating the release process! And sorry about the pain created by my missing --signoff as well as the backwards instructions (push tag before merging PR...)

/lgtm /approve

wallrj commented 9 months ago

/unhold

wallrj commented 9 months ago

@maelvls PTAL

jetstack-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [maelvls] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment