Closed wallrj closed 9 months ago
/hold until I've tested these instructions in the v1.12.7 release.
Name | Link |
---|---|
Latest commit | 17426e22d02c495e62cf1cda7798841815d3d032 |
Latest deploy log | https://app.netlify.com/sites/cert-manager-website/deploys/6578815bd2912c00085dcde9 |
Deploy Preview | https://deploy-preview-1363--cert-manager-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey. Thanks for updating the release process! And sorry about the pain created by my missing --signoff
as well as the backwards instructions (push tag before merging PR...)
/lgtm /approve
/unhold
@maelvls PTAL
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maelvls
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Preview: https://deploy-preview-1363--cert-manager-website.netlify.app/docs/contributing/release-process/#process-for-releasing-a-version
While releasing v1.13.3, I didn't signoff the commit which updates the
cmd/ctl/go.mod
file, which caused the PR to fail the DCO checks.--signoff
option in this PR.The problem was compounded by the fact that I had already pushed the
cmd/ctl@v1.13.3
tag to the cert-manager repo.