search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 337 forks source link

Regenerate approver-policy API docs #1415

Closed erikgb closed 9 months ago

erikgb commented 9 months ago

Also fixing a few bugs in the generate script caused by project restructuring.

inteon commented 9 months ago

/approve /lgtm Thanks for fixing the script and keeping the generated docs up-to-date.

erikgb commented 9 months ago

@inteon Any idea how to fix the failing build? The error message isn't clear to me.

inteon commented 9 months ago

@erikgb I see the following error: Expected a closing tag for <td> (153:9-153:13) This might be caused by an unescaped tag or something. Will investigate this further.

inteon commented 9 months ago

@erikgb this line seems to be broken: https://github.com/cert-manager/website/blob/5e67a122a5bd96c50c9a6ac037de91c55539e240/content/docs/policy/approval/approver-policy/api-reference.md?plain=1#L168 This might be a bug in the docs generator, but feel free to just fix the generated code if you do not want to root cause this.

erikgb commented 9 months ago

This might be a bug in the docs generator, but feel free to just fix the generated code if you do not want to root cause this.

Modifying something generated feels wrong. I'll try to get to the bottom of this. Any pointers would be appreciated.

netlify[bot] commented 9 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 06fd0aa8739c62ae0555ba983e9d30aceea1ad05
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65c35582c02e7000087b4f12
Deploy Preview https://deploy-preview-1415--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

erikgb commented 9 months ago

Finally! It works now. 🎉 PTAL!

jetstack-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [SgtCoDFish,inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment