search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

fix: TLSConfig secretName description #1419

Open arcezd opened 8 months ago

arcezd commented 8 months ago

On the DynamicServingConfig/TLSConfig are specifying the same secretNamespace description for the secretName attribute. DynamicServingConfig

jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 8 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 72d3d9b71fd1c9cd801e6e4943b7d52631d4a008
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65c1611107d4030007b37007
Deploy Preview https://deploy-preview-1419--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arcezd commented 7 months ago

Thanks for the clarification @wallrj, I just created the cert-manager PR 6785 with the changes, I guess we can close this one. Thanks!

wallrj commented 7 months ago

Thanks @arcezd. Once that cert-manager PR merges, we will have to regenerate the API documentation here, using the scripts in scripts/. So let's leave this open as a reminder.

cert-manager-prow[bot] commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.