cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Introduce variables for versions #1433

Closed inteon closed 7 months ago

inteon commented 7 months ago

Introduces a new variable format [[VAR::cert_manager_latest_version]] which can be used inside codeblocks and reads variables from the variables.json file. The solution is based on https://github.com/facebook/docusaurus/issues/395#issuecomment-1727777067 and works around an issue with MDX which does not allow you to have variables in codeblocks (https://github.com/orgs/mdx-js/discussions/2288).

netlify[bot] commented 7 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit e3eb94d26251584a659c02e043376475900f3460
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65e20a1eeddc02000867cd25
Deploy Preview https://deploy-preview-1433--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maelvls commented 7 months ago

Hey, great finding!

Can you update the Release Process document to reflect that? I think we can remove a lot of sed that I had added a while back?

/hold if you want to update the release process. /lgtm /approve

jetstack-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [maelvls] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
inteon commented 7 months ago

I'll create a seperate PR that updates the release doc. @maelvls /unhold