cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 337 forks source link

Explain why to use priorityClassName: system-cluster-critical in production #1444

Closed wallrj closed 8 months ago

wallrj commented 8 months ago

Preview: https://deploy-preview-1444--cert-manager-website.netlify.app/docs/installation/best-practice/#priority-class-name

I've done some research into the use-cases for setting priorityClassName and what priority class to use. I think cert-manager should use the built in priority class system-cluster-critical, and I've tried to justify that in the document.

It turns out that if you want to use that built in priority class, you (always?) also have to create a ResourceQuota resource, and I've tried to explain that too.

@hawksight interested to know what you think about this new recommendation.

Links:

netlify[bot] commented 8 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 22da1ab3c8f18d0102b9d447a23d8a88ff0c029f
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65f465fd80b8a40008df2ced
Deploy Preview https://deploy-preview-1444--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hawksight commented 8 months ago

/lgtm

hawksight commented 8 months ago

/approve

wallrj commented 8 months ago

/approve

jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawksight, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment