cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 337 forks source link

Update install instructions, making them consistent for all sub-projects #1449

Closed inteon closed 5 months ago

inteon commented 8 months ago

Goal: Reach base level of consistency for installation commands across all installation pages. Once we reach consistency, we can think about improving these instructions (keeping in mind the CRD changes coming in 1.15).

Next steps:

  1. Prepare 1.15 release (drastically simplify the CRD install section & use the single fool-proof install command everywhere)
jetstack-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 8 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 82de3c5556d04869f19f37be63f7153c3fbe4f71
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/66603f1b6e5f7d00087550e0
Deploy Preview https://deploy-preview-1449--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

inteon commented 8 months ago

Have you tested everything? No, the commands have not changed, I only expanded the flags. The only command that changed is the command that disables the approval-controller, and I copied that command from the approver-policy install page.

inteon commented 5 months ago

@wallrj

I updated the cert-manager instructions for approver-policy and csi-driver-spiffe (replaced helm install/ helm upgrade --install with helm upgrade --reuse-values. I also tested that this works as expected for the approver-policy installation.

ThatsMrTalbot commented 5 months ago

/lgtm

inteon commented 5 months ago

/approve

cert-manager-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment