Closed inteon closed 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Name | Link |
---|---|
Latest commit | 82de3c5556d04869f19f37be63f7153c3fbe4f71 |
Latest deploy log | https://app.netlify.com/sites/cert-manager-website/deploys/66603f1b6e5f7d00087550e0 |
Deploy Preview | https://deploy-preview-1449--cert-manager-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Have you tested everything? No, the commands have not changed, I only expanded the flags. The only command that changed is the command that disables the approval-controller, and I copied that command from the approver-policy install page.
@wallrj
I updated the cert-manager instructions for approver-policy and csi-driver-spiffe (replaced helm install
/ helm upgrade --install
with helm upgrade --reuse-values
. I also tested that this works as expected for the approver-policy installation.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: inteon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Goal: Reach base level of consistency for installation commands across all installation pages. Once we reach consistency, we can think about improving these instructions (keeping in mind the CRD changes coming in 1.15).
Next steps: