search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Docker testing and validation #1450

Open davidnoyes opened 6 months ago

jetstack-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidnoyes commented 6 months ago

While making changes to the documentation, I found having to install NodeJS to run the Next server and linting validation wasn't always desired. I've created a dockerfile and makefile to perform the same tasks.

netlify[bot] commented 6 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 695812126ae9d915cc1b74b3275c26d4c0895b83
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65f44edbd49def00072ee10d
Deploy Preview https://deploy-preview-1450--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ThatsMrTalbot commented 6 months ago

This does go against the conventions of the other repos, doing everything in docker by default.

But it also would make development easier, probably need some further opinions.

Other repos vendor all dependencies, though that could get heavy if we need to vendor nodejs itself

davidnoyes commented 6 months ago

I'd say that this change doesn't set a new default but just adds another option.

cert-manager-prow[bot] commented 5 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.