cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

feat: add makefile modules for local dev #1452

Closed ThatsMrTalbot closed 5 months ago

ThatsMrTalbot commented 6 months ago

This adds makefile-modules to the repo, this gives us:

jetstack-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 1974533173c1b0cbcc3ec0dfc8f56be768ffab3e
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/66266b9cb68dc500090d679a
Deploy Preview https://deploy-preview-1452--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

inteon commented 5 months ago

@ThatsMrTalbot I think we also need a make verify prowjob to verify that all generated files are valid.

ThatsMrTalbot commented 5 months ago

@ThatsMrTalbot I think we also need a make verify prowjob to verify that all generated files are valid.

Sure, we can add that. I was not too concerned with that initially since this is only used for local dev (mainly for vendoring nodejs locally tbh)

inteon commented 5 months ago

There were quite a few people who told me that setting up node and npm for this project is complex and that this PR will improve their experience. /approve /lgtm

cert-manager-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment