Closed ThatsMrTalbot closed 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Name | Link |
---|---|
Latest commit | 1974533173c1b0cbcc3ec0dfc8f56be768ffab3e |
Latest deploy log | https://app.netlify.com/sites/cert-manager-website/deploys/66266b9cb68dc500090d679a |
Deploy Preview | https://deploy-preview-1452--cert-manager-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@ThatsMrTalbot I think we also need a make verify
prowjob to verify that all generated files are valid.
@ThatsMrTalbot I think we also need a
make verify
prowjob to verify that all generated files are valid.
Sure, we can add that. I was not too concerned with that initially since this is only used for local dev (mainly for vendoring nodejs locally tbh)
There were quite a few people who told me that setting up node and npm for this project is complex and that this PR will improve their experience. /approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: inteon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This adds makefile-modules to the repo, this gives us:
make help
consistent with the other reposnode
andnpm
are vendored in _bin like we do for all other toolsmake build
andmake dev
to simply development (no need to install node/npm)