Closed vettom closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Name | Link |
---|---|
Latest commit | eed467cdf424aafbc7a1d3b2dd5e7c4f86fb997e |
Latest deploy log | https://app.netlify.com/sites/cert-manager-website/deploys/662a82c9e39655000832c254 |
Deploy Preview | https://deploy-preview-1466--cert-manager-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
Problem : https://github.com/cert-manager/cert-manager/issues/5557 Version validated on : v1.14.4 Fix: Incorrect value in Cluster Issuer section and missing IAM permission.
When using Route53 authentication, IAM RSA account is created and Cert-manager configured with respective ServiceAccount. Once this is done, there is no need to specify
role:
when creating ClusterIssuer as mentioned in the documentation. Adding Role will result in Access error."route53:GetChange" policy is required for Certmanager. Updated policy document with necessary permissions.