cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Fixing minor typos and missing dots #1485

Closed eduyubero closed 4 months ago

netlify[bot] commented 4 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit d4092940b4814fd07286d683e2bdc43b24cfbaa1
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/665d86a6ff90370008776013
Deploy Preview https://deploy-preview-1485--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

eduyubero commented 4 months ago

I've tested the link and now it seems to be correct.

hawksight commented 4 months ago

/lgtm /approve

ThatsMrTalbot commented 4 months ago

Is the api-reference.md file not autogenerated? Its taken from the comments of the golang types: https://github.com/cert-manager/trust-manager/blob/ebb6212c6a63fb9ad00f07957af49ea706e64ecb/pkg/apis/trust/v1alpha1/types_bundle.go#L109

eduyubero commented 4 months ago

@SgtCoDFish I have done all the changes requested but now a commit (ae4b275026a8b8915be48d02551cc0ddd7237c01) is not signoff and the workflow is paused.

Can this be skipped? I tried rebasing by doing: git rebase --signoff @~3 but still the commit remains unsigned. :__(

eduyubero commented 4 months ago

Please can somebody help. That single commit that was not signedoff can not be amended. Shall I just create a new PR from scratch with the current changes and delete this one?

ThatsMrTalbot commented 4 months ago

I would do the following

eduyubero commented 4 months ago

@ThatsMrTalbot It worked. Thank you!!

cert-manager-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawksight, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [SgtCoDFish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hawksight commented 4 months ago

/lgtm

eduyubero commented 4 months ago

Thanks for the approvals!

How does the PR merge policy works in this repo? will this be merged at the end of the day? is there a particular day of the week/month when approved PR get merged? ... I'm just curious.

ThatsMrTalbot commented 4 months ago

The bot should approve it once both the lgtm and approved labels exist, looks like its having a nap at the moment

ThatsMrTalbot commented 4 months ago

Random shot in the dark /ok-to-test

SgtCoDFish commented 4 months ago

Not sure why this wasn't auto-merged but I've merged now. Thanks again @eduyubero !