cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

chore: use cm maintainers in owners #1508

Closed ThatsMrTalbot closed 3 months ago

ThatsMrTalbot commented 3 months ago

Also done in this PR is a klone upgrade, to get the latest OWNERS_ALIASES.

netlify[bot] commented 3 months ago

Deploy Preview for cert-manager-website ready!

Name Link
Latest commit 7a450b31c3900a40191618aa0dfbc49cd0175c2f
Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/667a89a7a247f5000829987a
Deploy Preview https://deploy-preview-1508--cert-manager-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

inteon commented 3 months ago

/approve /lgtm

cert-manager-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maelvls commented 3 months ago

Lots of unrelated changes in this PR but I guess I'm OK with that. What caught my eye is that the PR description doesn't explain the only actual change in this PR: you added yourself to the approvers (which I'm absolutely OK with, but that needs a line in the PR description at the very least)

ThatsMrTalbot commented 3 months ago

Lots of unrelated changes in this PR, but I guess I'm OK with that. What caught my eye is that the PR description doesn't explain the only actual change in this PR: you added yourself to the approvers (which I'm absolutely OK with, but that needs a like in the PR description at the very least)

@maelvls all the other changes are from the klone upgrade (the upgrade of makefile modules) - which I did mention in the PR description.