search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 333 forks source link

Bump npm dependencies #1511

Closed inteon closed 2 months ago

inteon commented 2 months ago

Upgrades node, npm and the npm dependencies. Additionally, uses the cert-manager.io preview which is now hosted in the CNCF Netlify. We should also update the tide Netlify check to point to this CNCF Netlify site: https://github.com/cert-manager/testing/pull/1037.

netlify[bot] commented 2 months ago

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
Latest commit bcf50d0c4530af45d411f00eca8be6f436f9fd7d
Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/668bea3bd091f20007853840
Deploy Preview https://deploy-preview-1511--cert-manager.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ThatsMrTalbot commented 2 months ago

Just browsing around the preview the only difference I have found so far is here: https://deploy-preview-1511--cert-manager.netlify.app/docs/installation/kubectl/#2-optional-end-to-end-verify-the-installation vs https://cert-manager.io/docs/installation/kubectl/#2-optional-end-to-end-verify-the-installation

Where the example is syntax highlighted on the old page but not the new. IDK if there are more examples of codeblocks rendering differently

inteon commented 2 months ago

Just browsing around the preview the only difference I have found so far is here: https://deploy-preview-1511--cert-manager.netlify.app/docs/installation/kubectl/#2-optional-end-to-end-verify-the-installation vs https://cert-manager.io/docs/installation/kubectl/#2-optional-end-to-end-verify-the-installation

Where the example is syntax highlighted on the old page but not the new. IDK if there are more examples of codeblocks rendering differently

I think this is probably ok, the yaml rendering still works as expected (which I think is most important):

UPDATE: looks like there is only a small set of languages that is supported now: https://github.com/FormidableLabs/prism-react-renderer/blob/c914fdea48625ba59c8022174bb3df1ed802ce4d/packages/generate-prism-languages/index.ts#L9-L23

inteon commented 2 months ago

I re-added support for bash: https://github.com/cert-manager/website/pull/1511/commits/bcf50d0c4530af45d411f00eca8be6f436f9fd7d#diff-e1c65828ec7dd4ccafa336a5e88f159217fe83dddb2aadf82d486b2232193e32R10-R12

ThatsMrTalbot commented 2 months ago

Cant find anything else broken from clicking around /lgtm

inteon commented 2 months ago

/approve

cert-manager-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment