cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
54 stars 336 forks source link

Cview-issuer for cert-manager #1541

Closed djkormo closed 1 month ago

djkormo commented 2 months ago

New issuer has been created for cert-manager. It uses cview as dedicated CA. The website of this produkt product https://www.secure-ly.com/c-view-professional-certificates-lifecycle-management/ . Issuer is not open-sourced.

netlify[bot] commented 2 months ago

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
Latest commit 1b449949938f26057ccba2ceee3b07ca4cc3c625
Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66f1cfd31feebf0008640134
Deploy Preview https://deploy-preview-1541--cert-manager.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Dror1966 commented 2 months ago

Hi, Can you prioritize this issue?

djkormo commented 2 months ago

@jakexks Please help me with this npm check. I do not understand why it is failed.

[spelling]     content/docs/configuration/issuers.md
[spelling]        18 | | 🥈   | cview-issuer                | [📄][config: 
[spelling]        18 | ig:cview-issuer]           | [Cview issuer][ca:cview-issuer]  
djkormo commented 2 months ago

The spelling has been corrected.

djkormo commented 2 months ago

/approve

djkormo commented 1 month ago

/assign

cert-manager-prow[bot] commented 1 month ago

@djkormo: you cannot LGTM your own PR.

In response to [this](https://github.com/cert-manager/website/pull/1541#issuecomment-2366810173): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
djkormo commented 1 month ago

/assing jakexks

djkormo commented 1 month ago

/assign @sorah

cert-manager-prow[bot] commented 1 month ago

@djkormo: GitHub didn't allow me to assign the following users: sorah.

Note that only cert-manager members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/cert-manager/website/pull/1541#issuecomment-2366811165): >/assign @sorah Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
djkormo commented 1 month ago

/assing @jakexks

cert-manager-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djkormo, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/website/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
djkormo commented 1 month ago

Code was written on the base from this repo https://github.com/cert-manager/sample-external-issuer/tree/main

It does handle approval.

inteon commented 1 month ago

/unhold