search

cert-manager / website

Source code for the cert-manager.io website, including project documentation
https://cert-manager.io
Apache License 2.0
53 stars 332 forks source link

Tables nested in lists are broken on Hugo 0.59.1 #507

Closed maelvls closed 3 years ago

maelvls commented 3 years ago

We currently use Hugo 0.59.1 for building https://cert-manager.io.

In #496, I added a table to the page https://cert-manager.io/docs/contributing/release-process/, and it looks totally broken:

hugo-0.59.1

Locally, I run Hugo v0.78.1 and the rendered table looks like this:

hugo-0.78.1

Should we upgrade our version of Hugo? I am worried about any improbable breakage that may happen... 😅

edeediong commented 3 years ago

/assign @edeediong

maelvls commented 3 years ago

Not sure why, but the Docsy theme (we are using this commit) does not seem to like the fact that I am embedding the table inside a list... When I put the same table at the top-level of the Markdown file, then it looks much better (this screenshot was taken using Hugo v0.78.1):

top-level

maelvls commented 3 years ago

Just to make sure that we wouldnt break the world by upgrading, here is the diff:

curl -L https://github.com/gohugoio/hugo/releases/download/v0.59.1/hugo_extended_0.59.1_macOS-64bit.tar.gz | tar xz && 
 mv hugo ./hugo-v0.59.1 && chmod +x ./hugo-v0.59.1
curl -L https://github.com/gohugoio/hugo/releases/download/v0.78.1/hugo_extended_0.78.1_macOS-64bit.tar.gz | tar xz &&  mv hugo ./hugo-v0.78.1 && chmod +x ./hugo-v0.78.1
./hugo-v0.59.1 -d site-v0.59.1
./hugo-v0.78.1 -d site-v0.78.1
diff -u ./site-v0.59.1 ./site-v0.78.1
The big diff ```diff --- ./site-v0.59.1/docs/contributing/release-process/index.html 2021-04-07 20:22:01.000000000 +0200 +++ ./site-v0.78.1/docs/contributing/release-process/index.html 2021-04-07 20:22:04.000000000 +0200 @@ -4,7 +4,7 @@ - + @@ -24,18 +24,18 @@ Release Process | cert-manager + The release process takes about 40 minutes. You must have time to complete all the steps. + You currently need to be at Jetstack to get the required GitHub and GCP permissions." /> - - - - + The release process takes about 40 minutes. You must have time to complete all the steps. + You currently need to be at Jetstack to get the required GitHub and GCP permissions."> + + @@ -44,14 +44,15 @@ + The release process takes about 40 minutes. You must have time to complete all the steps. + You currently need to be at Jetstack to get the required GitHub and GCP permissions."/> - - + + Githubissues.
  • Githubissues is a development platform for aggregating issues.