search

certat / do-portal

This project is in maintenance mode and will only receive bug fixes, but no new features. A new version of this software is being developed.
5 stars 5 forks source link

Make email address mandatory for role "Single Point of Contact (SPoC)" #110

Closed certrik closed 4 years ago

certrik commented 4 years ago

The e-mail address field has to be filled with a valid email address if assigning the role "Single Point of Contact (SPoC)" [database id 4] to a contact. The email addres doesn't need to be validated to be working but to have at least some proper formatting e.g "something @ someotherstuff . even more stuff". Don't forget the * to indicate that it is a mandatory field. Display a meaningful error.

MarkHofstetter commented 4 years ago

which email address, the user email or the membership email

certrik commented 4 years ago

the membership email.

davewood commented 4 years ago

https://github.com/certat/do-portal/commit/712580d917fcaf5fb5e693bb0761f1bd8eb80167

as soon as I know the role_id of SPOC this issue should be fixed. waiting for input.

certrik commented 4 years ago

Well if I remember correctly it is id 4 as stated in the issue description.

MarkHofstetter commented 4 years ago

Please never ever use ids for identifying rows/objects those are "random" and may differ in each installation - please use the textual identifier

davewood commented 4 years ago

https://github.com/certat/do-portal/commit/ebc7fe6f7ff917761ca87feaabf610ea5cf1b800

email required (js enforcment only) for SPOC contacts

certrik commented 4 years ago

@davewood @MarkHofstetter The "CISO" role needs a phone number now (for whatever reason), but role "Single Point of Contact (SPoC)" can still be created without providing an email address.

davewood commented 4 years ago

phone or mobile?

davewood commented 4 years ago

also, how do you want to make this requirement visible if its mobile OR phone. currently we display a * next to the attribute but if one of 2 is required that doesnt really work.

certrik commented 4 years ago

We don't need the phone number or mobile number and there are no mandatory fields for CISO. The issue concerns a mandatory email address for the role "Single Point of Contact (SPoC)". That the email address is mandatory should be indicated with a * at the email field description.

certrik commented 4 years ago

Short answer ... Please make it so that the email address for the role "Single Point of Contact (SPoC)" is mandatory and that it is visibly indicated.

davewood commented 4 years ago

fixed:

https://github.com/certat/do-portal/commit/10f8b662fd03963f02eeaaab3c8204e16bc978a8 https://github.com/certat/do-portal/commit/3db5b4f4f12b15966e7101cb4b88005483323503