certat / do-portal

This project is in maintenance mode and will only receive bug fixes, but no new features. A new version of this software is being developed.
5 stars 5 forks source link

create vs update user, different validation #65

Closed davewood closed 5 years ago

davewood commented 5 years ago

creating a user requires membership data to be filled out.

you can omit phone, email, address and submit and no warning is shown.

if you edit the same user now and just click save on the same membership you get an error saying

Attribute error. Invalid email, phone or mobile?

which membership attributes are required and which are optional?

davewood commented 5 years ago

better explanation: membership-create doesnt validate/require phone/addr/email but membership-update does.

certrik commented 5 years ago

It should not be required to add a phone number or email in membership roles. But if it is provided it should be validated. At least for most roles. Is there a possibility to define certain membership roles that need an email or phone or both?

MarkHofstetter commented 5 years ago

actually there if there is a role sms_alerting which require a mobile number

certrik commented 5 years ago

That is what I meant. But please fix ...

better explanation: membership-create doesnt validate/require phone/addr/email but membership-update does.

MarkHofstetter commented 5 years ago

fixed