search

certat / do-portal

This project is in maintenance mode and will only receive bug fixes, but no new features. A new version of this software is being developed.
5 stars 5 forks source link

Contacts: Use full browser window #67

Closed certrik closed 5 years ago

certrik commented 5 years ago

Please make it so that /#!/user_list uses all the available space in the browser window.

davewood commented 5 years ago

https://github.com/certat/customer-portal/commit/0e3c3bfbbf3da6bbf351dd8f6e6d02edb770d048

certrik commented 5 years ago

Nearly correct. Now the whole table is diplayed at once. But what is needed is that the browser window is filled without the need for scrolling. Scrolling within the table is fine.

davewood commented 5 years ago

why is that needed? increasing the table dynamically is tricky enough as it is, pulling in more dependencies (screen size) will make the code even more un-maintainable. not to mention the mental gymnastics required to pull it off in the first place.

certrik commented 5 years ago

Well okay. Than please just make the table a bit larger that it better fits the browser window. It just felt to small in the original. Having the whole table loaded at once, like now, is just too slow.

davewood commented 5 years ago

larger? you mean the width? that's a fixed width of the layout inherited by the certeu project. Do you want the entire page to be wider?

davewood commented 5 years ago

http://bootstrapdocs.com/v3.4.1/docs/css/#grid-options

davewood commented 5 years ago

max table height set to 600px: commit -> git: 5a3dde7