certbot / certbot-docker

95 stars 23 forks source link

Install pipstrap to pin setuptools/pip/wheels #23

Closed adferrand closed 4 years ago

adferrand commented 4 years ago

So, setuptools broke the installation setup, by removing a deprecated API that is still used by some of our dependencies (see https://github.com/pypa/setuptools/issues/2017)

This PR fixes the Docker build by using pipstrap to pin pip/setuptools/wheels, like it is done in several critical places (certbot-auto, ...).

An issue in certbot is opened to fix more generally the problem in most recent versions of setuptools: https://github.com/certbot/certbot/issues/7976

adferrand commented 4 years ago

It rebuilt locally all dockers (certbot + dns plugins) for the three architectures, and all have passed.