Add missing error types and descriptions from RFC 8555 to acme

certbot / certbot

Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server. It can also act as a client for any other CA that uses the ACME protocol.

Other

31.28k stars 3.38k forks source link

Add missing error types and descriptions from RFC 8555 to acme #7116

Closed bmw closed 5 years ago

bmw commented 5 years ago

https://github.com/certbot/certbot/blob/b0d960f102c998d8231c0ee48952b488f10864ac/acme/acme/messages.py#L20-L36 defines a number of ACME error types and their descriptions, however, that list is not up to date. We should add the missing error types from https://tools.ietf.org/html/rfc8555#section-6.7 to this dict.

ddrobner commented 5 years ago

I made a pull request for this. Feel free to suggest any changes that you see fit.

bmw commented 5 years ago

Fixed in #7131.