search

certera-io / certera

A central validation server for Let's Encrypt certificates
https://docs.certera.io
Other
72 stars 14 forks source link

Upgrade packages to minimize the size of dependency graph #26

Open sucrose0413 opened 3 years ago

sucrose0413 commented 3 years ago

Hi@certeraio, I found an issue in the Certera.Data.csproj:

Packages Certes v2.3.3, Microsoft.AspNetCore.Identity.EntityFrameworkCore v3.1.0, Microsoft.EntityFrameworkCore v3.1.0, Microsoft.EntityFrameworkCore.Design v3.1.0, Microsoft.EntityFrameworkCore.Sqlite v3.1.0 and Microsoft.EntityFrameworkCore.Tools v3.1.0 transitively introduce 107 dependencies into certera’s dependency graph (see dependency graph before upgrades), while Certes v2.3.4, Microsoft.AspNetCore.Identity.EntityFrameworkCore v3.1.1, Microsoft.EntityFrameworkCore v3.1.16, Microsoft.EntityFrameworkCore.Design v3.1.5, Microsoft.EntityFrameworkCore.Sqlite v3.1.1 and Microsoft.EntityFrameworkCore.Tools v3.1.1 can only introduce 73 dependencies (see dependency graph after upgrades).

These upgrades can help project minimize the size of dependency graph. Hope the PR can help you.

Best regards, sucrose

certeraio commented 3 years ago

Hi @sucrose0413 . I've been meaning to upgrade a bunch of other things too. I've created a build with dotnet 5 and a bunch of dependencies all upgraded. Please check it out here: https://github.com/certera-io/certera/releases/tag/2.2.0-beta

picanl commented 3 years ago

Is this project still active??

Getting the following error with 2.2.0-beta 

info: Certera.Web.Services.HostedServices.QueuedHostedService[0]
      Queued Hosted Service is starting.
info: Certera.Web.Services.HostedServices.DomainScanIntervalService[0]
      Domain scanning service starting.
info: Certera.Web.Services.HostedServices.CertificateAcquiryService[0]
      Certificate discovery service starting.
info: Certera.Web.Services.HostedServices.CertificateChangeNotificationService[0                                                                                                                                                             ]
      Certificate change notification service starting.
info: Certera.Web.Services.HostedServices.CertificateExpirationNotificationServi                                                                                                                                                             ce[0]
      Certificate expiration notification service starting.
crit: Microsoft.AspNetCore.Hosting.Diagnostics[6]
      Application startup exception
      System.NotSupportedException: CodeBase is not supported on assemblies load                                                                                                                                                             ed from a single-file bundle.