search

certifi / erlang-certifi

SSL Certificates for Erlang
Other
131 stars 33 forks source link

Remove expired AddTrust root CA #39

Closed garthk closed 3 years ago

garthk commented 4 years ago

Would provide a tighter fix than {insecure, true} for those relying on certifi; see benoitc/hackney#633.

garthk commented 4 years ago

The build failure is entirely fair: that's not a good solution.

garthk commented 4 years ago

Better. Not great, but better.

isubasti commented 4 years ago

apparently there's another expired CA(Staat der Nederlanden Root CA - G2), https://github.com/elixir-mint/castore/pull/17#issuecomment-637495179 so might want to remove that as well. luckily no more this year but there will be another 5 expiring next year

Vagabond commented 3 years ago

@benoitc this would be really good to merge as it's breaking a bunch of stuff in the field because something is not doing any fallback resolution for certificate chains that include this cert.

benoitc commented 3 years ago

i will take care of it today (that and others things). thanks cor the head up!

On Wed 30 Sep 2020 at 22:42, Andrew Thompson notifications@github.com wrote:

@benoitc https://github.com/benoitc this would be really good to merge as it's breaking a bunch of stuff in the field because something is not doing any fallback resolution for certificate chains that include this cert.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/certifi/erlang-certifi/pull/39#issuecomment-701633561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADRIRRF7D4PAQXWADPBSDSIOJ2JANCNFSM4NQN5RDQ .

-- Sent from my Mobile

arjan commented 3 years ago

Any progress? :-)

benoitc commented 3 years ago

Any progress? :-)

release will land tomorrow. Had to postpone it during the we.

mbklein commented 3 years ago

Is there any chance of getting a release out soon without the expired root certs? We've had a workaround in place, but it would be great to have it working straight out of the gate.

arjan commented 3 years ago

Ping...