Closed paulo-ferraz-oliveira closed 3 years ago
Hi. Is this OK for merging? Do you want further changes?
Ping.
sorry I have been sidetracked. I have like on hackney created an empty action file. Let me know if you want to do the merge. Otherwise I can probably do it later today.
I can rebase and test it before the merge, no prob. It's safer this way.
Edit: rebased and force-pushed. Let's see what happens 😄
Failing. Happy about the previous decision to rebase. Let me check what's happening.
Failing. Happy about the previous decision to rebase. Let me check what's happening.
Thanks! it seems to run the last part of the action outside of the repository... not sure why though
All GitHub Actions tests are passing.
Failing. Happy about the previous decision to rebase. Let me check what's happening.
Thanks! it seems to run the last part of the action outside of the repository... not sure why though
Well, what happens is that actions/checkout@v2
only pulls stuff as a Git repo from 2.18 (which is not in some containers by default - which is the reason I added the install procedure). From then on it seems straightforward.
thanks for the changes!
Differences to previous CI (Travis):
set -e/+e
rebar3
instead of installing latest (don't know if this is a hard requirement)if [[ "$TRAVIS_OTP_RELEASE" = '20.2' ]] && [[ "$TRAVIS_EVENT_TYPE" = 'cron' ]]; then make update; fi
since no 20.2 was configured (which means this wasn't running, recently)