certifi / erlang-certifi

SSL Certificates for Erlang
Other
131 stars 33 forks source link

Implement GitHub Actions #42

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

Differences to previous CI (Travis):

paulo-ferraz-oliveira commented 3 years ago

Hi. Is this OK for merging? Do you want further changes?

paulo-ferraz-oliveira commented 3 years ago

Ping.

benoitc commented 3 years ago

sorry I have been sidetracked. I have like on hackney created an empty action file. Let me know if you want to do the merge. Otherwise I can probably do it later today.

paulo-ferraz-oliveira commented 3 years ago

I can rebase and test it before the merge, no prob. It's safer this way.

Edit: rebased and force-pushed. Let's see what happens 😄

paulo-ferraz-oliveira commented 3 years ago

Failing. Happy about the previous decision to rebase. Let me check what's happening.

benoitc commented 3 years ago

Failing. Happy about the previous decision to rebase. Let me check what's happening.

Thanks! it seems to run the last part of the action outside of the repository... not sure why though

paulo-ferraz-oliveira commented 3 years ago

All GitHub Actions tests are passing.

paulo-ferraz-oliveira commented 3 years ago

Failing. Happy about the previous decision to rebase. Let me check what's happening.

Thanks! it seems to run the last part of the action outside of the repository... not sure why though

Well, what happens is that actions/checkout@v2 only pulls stuff as a Git repo from 2.18 (which is not in some containers by default - which is the reason I added the install procedure). From then on it seems straightforward.

benoitc commented 3 years ago

thanks for the changes!