search

certifi / erlang-certifi

SSL Certificates for Erlang
Other
131 stars 33 forks source link

Add more entries on .gitignore #43

Closed enidgjoleka closed 3 years ago

enidgjoleka commented 3 years ago

This PR adds one more entry on .gitignore:

paulo-ferraz-oliveira commented 3 years ago

As per https://github.com/uwiger/parse_trans/pull/44#issuecomment-774344538:

"

.idea -> needed for developers who work intelliJ Idea

Shouldn't developers who use this, include the exception in their own .gitignore_global? To me, .gitignore was always about files that the application itself might generate, e.g. logs, _build, rebar3.crashdump, ... "

I'd apply the same reasoning as with the .DS_Store, for example (generated in Mac).

(imagine we add exceptions for all editors...)

Also, ebin/ is for rebar 2. Still valid to use, but not the one erlang-certifi aims for.

enidgjoleka commented 3 years ago

I will remove the .idea entry.

As I mentioned on the other PR: https://github.com/uwiger/parse_trans/pull/44#issuecomment-774920967 the system I am working on is quite old and does not make use of rebar3 yet. Hence, we need to deal with ebin.

paulo-ferraz-oliveira commented 3 years ago

Hence, we need to deal with ebin.

Sure, ebin is reasonable, which is why I wrote "Also, ebin/ is for rebar 2. Still valid to use, but not the one erlang-certifi aims for.".

enidgjoleka commented 3 years ago

Hi @paulo-ferraz-oliveira I was wondering if there is anything left in this PR that might stop it from being merged. If so please let me know and I would be happy to work on it.

Thanks.

paulo-ferraz-oliveira commented 3 years ago

Hi, @enidgjoleka. I don't think there is anything missing, apart from the approval and merging by @benoitc.

benoitc commented 3 years ago

merged. Sorry for the delay.