search

certifi / erlang-certifi

SSL Certificates for Erlang
Other
131 stars 33 forks source link

Prevent silent error when reading certificates file #44

Closed g-andrade closed 3 years ago

g-andrade commented 3 years ago

Ensure that, if reading the certificates file fails, compilation of certifi.erl also fails.

Pattern matching within list comprehensions was the cause of the issue this PR intends on fixing, since failed patterns are silently ignored.

g-andrade commented 3 years ago

Incidentally, CI is failing due to what I presume is the original issue I intended to give more visibility to (a change to application load paths in rebar3 3.14.4.)

Oh well.

paulo-ferraz-oliveira commented 3 years ago

Would it be acceptable to ask you to add dialyzer to CI? I just ran this locally, thought I had an issue, then didn't. Finally I looked at CI and dialyzer isn't there. (still no issue) So all's fine except for a missing dialyzer.

g-andrade commented 3 years ago

@paulo-ferraz-oliveira done in f39e3eb.

paulo-ferraz-oliveira commented 3 years ago

Cool. Very nice.

As for

Incidentally, CI is failing due to what I presume is the original issue I intended to give more visibility to (a change to application load paths in rebar3 3.14.4.)

yeah, the container holds rebar3 3.14.4. 😄 It'll soon be fixed, hopefully.