search

certificationy / symfony-pack

A series of questions to prepare for the Symfony certification
https://certification.symfony.com/
MIT License
325 stars 131 forks source link

Doubt about an answer marked as right #76

Closed l-vo closed 3 years ago

l-vo commented 5 years ago

Are you sure for this one ? https://github.com/certificationy/symfony-pack/blob/bb5c67986573b52e574c7938c2c46fdc7c746fdc/data/command-line.yml#L147

Event dispatching seems not be deactivable: https://github.com/symfony/symfony/blob/4d21ab4e7bbc1578c7f23b65f56fa605aff4fb10/src/Symfony/Component/Console/Application.php#L916 In the code above, there is no condition checking if events are disabled.

a-menshchikov commented 3 years ago

@l-vo https://github.com/symfony/symfony/blob/4d21ab4e7bbc1578c7f23b65f56fa605aff4fb10/src/Symfony/Component/Console/Application.php#L918 if ($event->commandShouldRun()) { ... checks is the command has been disabled.

l-vo commented 3 years ago

@a-menshchikov the answer is about the possibility to disable console events, not the possibility to disable console commands.

a-menshchikov commented 3 years ago

Oh, you are right! It seems to me as a misprint.

l-vo commented 3 years ago

@a-menshchikov maybe 🙂

mickaelandrieu commented 3 years ago

Yes, you're right : feel free to contribute the deck to make this answer right please 👼

Regards,

a-menshchikov commented 3 years ago

@l-vo this issue seems as outdated. Maybe it should be closed?

l-vo commented 3 years ago

Fixed by #87