certsocietegenerale / fame

FAME Automates Malware Evaluation
https://certsocietegenerale.github.io/fame/
GNU General Public License v3.0
847 stars 168 forks source link

[Docker] `dockerd` sometimes fail to start inside the worker #131

Closed Augustin-FL closed 1 year ago

Augustin-FL commented 1 year ago

Description

When using docker, the worker sometimes does not run properly after several restarts, because dockerd fail to start properly.

The issue is random and only arise after multiple restart of the fame docker instances.

Steps to Reproduce

Expected behavior

dockerd should be able to always run correctly inside the worker container.

Debug

The root cause seems to be related to how docker stops the containers: When the worker is being shut down, dockerd sometimes doesn't have the time to stop properly inside the worker. This causes leftover .sock & .pid files to remain on the worker's disk. dockerd will refuse to run on next restart because of these leftover files.