search

certtools / intelmq-manager

IntelMQ Manager is a graphical interface to manage configurations for IntelMQ framework.
https://docs.intelmq.org/latest/user/manager/
102 stars 56 forks source link

Added Auth Token In Save Data Requests #245

Closed MarcosxDeveloper closed 3 years ago

ghost commented 3 years ago

Works for me and fixes some unclear behaviour. @e3rd @bernhard-herzog Do you see any obstacles?

MarcosxDeveloper commented 3 years ago

thank you @e3rd,

I tried the script you recommended and it works great.

so I added that solution to my pull request.

e3rd commented 3 years ago

Your reaction was blazingly fast. One thing, the method you add is $.authenticatedAjax – I think this method does not exist. The method in static.js is named authenticatedAjax and $ stands for jQuery -> and there is no such method in the jQuery namespace. Isn't this a bug?

MarcosxDeveloper commented 3 years ago

you're right @e3rd,

sorry for the error, I did not realize in the test that it had an active cache of the old files.

I already update the pull request again now if with the code 100% tested

ghost commented 3 years ago

Thanks for the review @e3rd and @MarcosxDeveloper for your (quick!) contribution!

ghost commented 3 years ago

Merged in 144a9d9f32937c57bc9a017ed10f7880b37248d2

Will be in the next bugfix release 2.3.1.

Thanks again!