certtools / intelmq-manager

IntelMQ Manager is a graphical interface to manage configurations for IntelMQ framework.

https://docs.intelmq.org/latest/user/manager/

102 stars 56 forks source link

Fixes #270

Closed monoidic closed 3 years ago

monoidic commented 3 years ago

This PR:

fixes an issue left over from #264, when editing path names, with -queue suffixes not being properly added/removed
makes Mako use UTF-8 by default, hopefully fixing #266
adds HTML escaping where possible, handling #267, #268, #269, and making show_error displaying formatted HTML opt-in

ghost commented 3 years ago

Wow, that was fast :flushed:

266 (introduced by myself) seems to be fixed

CodeQL reports

Fixed alerts

Incomplete string escaping or encoding (intelmq_manager/static/js/monitor.js#L547) Client-side cross-site scripting (intelmq_manager/static/js/monitor.js#L291) Client-side cross-site scripting (intelmq_manager/static/js/monitor.js#L314)

ghost commented 3 years ago

@e3rd Could you have a look please?

monoidic commented 3 years ago

Got a couple of other things lined up I'll tack onto this PR next week, actually.

ghost commented 3 years ago

Many thanks also from my side for all your hard work! We really appreciate that.